[IMPALA-11645] Remove PrintThriftEnum functions in debug-utils.cc

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Epic Color: ghx-label-5
• Assignee: Daniel Becker
• Reporter: Daniel Becker
• Created: 10/Oct/22 15:15
• Updated: 22/Feb/23 08:27
• Resolved: 20/Oct/22 12:09

Description

Before IMPALA-5690 we implemented operator<< for Thrift enums in Impala code. These functions printed the names of the enums.

Then we upgraded to Thrift 0.9.3, but that release included THRIFT-2067, which implemented operator<< for Thrift enums, but printed the number value of enums instead of their names. To preserve the old behaviour in Impala, we renamed our own implementations of operator<< to PrintThriftEnum, a function that we defined for each Thrift enum we used, and which returned a string with the names - not the numbers - of the enums.

After upgrading Thrift to a version that included THRIFT-3921 (any version starting from 0.11.0), these PrintThriftEnum functions are no longer necessary as the operator<< provided by Thrift now prints the names of enums, which is the behaviour we want.

Issue Links

• relates to: IMPALA-11869 Use to_string() in PrintValue for printing Thrift types