[IMPALA-11621] testdata/bin/kill-hive-server.sh should remove the HiveServer2 pid file

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Infrastructure
• Epic Color: ghx-label-11
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 28/Sep/22 18:09
• Updated: 07/Nov/22 21:27
• Resolved: 01/Oct/22 03:38

Description

With HIVE-22193, Hive added a graceful stop functionality that also changed some startup scripts. Hive now keeps a file with the HiveServer2's pid and checks to see if it is already running before starting up. testdata/bin/kill-hive-server.sh uses testdata/bin/kill-java-service.sh, and it doesn't know to remove the pid file. Since testdata/bin/kill-java-service.sh would fail if it was unable to stop HiveServer2, it should be safe to remove the pid file after that command succeeds.

If we don't remove the pid file, the OS might reuse the pid and this could interfere with HiveServer2 startup.