[IMPALA-11569] Run finalize.sh in bin/jenkins/all-tests.sh even if dataload fails

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Infrastructure
• Epic Color: ghx-label-6
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 08/Sep/22 21:44
• Updated: 05/Nov/22 15:58
• Resolved: 09/Sep/22 20:05

Description

bin/jenkins/all-tests.sh (used for precommit Jenkins jobs) has "set -oeu pipefail" set, so if a command fails, it will exit. Currently, it sources bin/bootstrap_development.sh, so if that fails it will not run finalize.sh.

source bin/bootstrap_development.sh
...
RET_CODE=0
if ! bin/run-all-tests.sh; then
  RET_CODE=1
fi
# Shutdown minicluster at the end
testdata/bin/kill-all.sh
bin/jenkins/finalize.sh
exit $RET_CODE

finalize.sh is useful for resolving minidumps and generating JUnitXML. bootstrap_development.sh runs dataload, so Impala could crash and finalize.sh wouldn't run. We should change it so that finalize.sh runs even if dataload fails.