[IMPALA-11419] Incremental build is broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.2.0
• Component/s: Infrastructure
• Epic Color: ghx-label-4
• Assignee: Zoltán Borók-Nagy
• Reporter: Zoltán Borók-Nagy
• Created: 06/Jul/22 15:58
• Updated: 19/Sep/22 11:19
• Resolved: 19/Sep/22 11:19

Description

IMPALA-11384 broke incremental builds because:

• added a custom target that always rewrites a few generated header files
  • The files are getting included directly/indirectly in most files, so we always need to recompile a large part of the project
• Didn't remove ${THRIFT_FILE_WE}_constants.cpp/h dependency from common/thrift/CMakeLists.txt
  • These files are not generated anymore, so the build system always reconstruct all the generated files (because *_constant.cpp/h is always missing), and then builds every target that depend on them.

IMPALA-11415 fixes a sporadic error during data loading, but it only covers the root cause, i.e. we unnecessarily regenerate thrift files.