[IMPALA-11403] CMake warning triggered by a sed regexp in common/thrift

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Epic Color: ghx-label-8
• Assignee: Laszlo Gaal
• Reporter: Laszlo Gaal
• Created: 28/Jun/22 19:09
• Updated: 01/Aug/22 08:41
• Resolved: 01/Aug/22 08:41

Description

While investigating a different issue, a CMake warning was noticed in the build output, complaining about a sed regexp in a build rule:

00:02:26.836 CMake Warning (dev) at common/thrift/CMakeLists.txt:238 (add_custom_target):
00:02:26.836   Syntax error in cmake code at
00:02:26.836 
00:02:26.836     /home/ubuntu/Impala/common/thrift/CMakeLists.txt:239
00:02:26.836 
00:02:26.836   when parsing string
00:02:26.836 
00:02:26.836     's|\(dispatchCallTemplated.*\));|\1) override;|'
00:02:26.836 
00:02:26.836   Invalid escape sequence \1
00:02:26.836 
00:02:26.836   Policy CMP0010 is not set: Bad variable reference syntax is an error.  Run
00:02:26.836   "cmake --help-policy CMP0010" for policy details.  Use the cmake_policy
00:02:26.836   command to set the policy and suppress this warning.
00:02:26.836 This warning is for project developers.  Use -Wno-dev to suppress it.
00:02:26.836 

This probably indicates an escaping problem: too many programs use the backslash for escaping various special characters.

Issue Links

• is broken by: IMPALA-11384 Upgrade CPP thrift components to thrift-0.16.0