Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-11366

Impala-shell failed to build if the build date contains Non-ASCII characters

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 4.2.0
    • Impala 4.2.0
    • Infrastructure
    • None
    • ghx-label-10

    Description

      I encountered a build failure locally:

      Building package...
      Traceback (most recent call last):
        File "setup.py", line 30, in <module>
          from impala_shell import impala_build_version
        File "/home/quanlong/workspace/Impala/shell/packaging/staging/impala_shell_package/impala_shell/impala_build_version.py", line 26
      SyntaxError: Non-ASCII character '\xe5' in file /home/quanlong/workspace/Impala/shell/packaging/staging/impala_shell_package/impala_shell/impala_build_version.py on line 26, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

      line 26 at shell/packaging/staging/impala_shell_package/impala_shell/impala_build_version.py does contain Non-ASCII characters:

       19 def get_version():
       20   return "4.2.0-SNAPSHOT"
       21 
       22 def get_git_hash():
       23   return "2b9d986582198903bac63e9ce8dc31c06742d3ee"
       24 
       25 def get_build_date():
       26   return "2022年 06月 17日 星期五 08:26:01 CST"
      

      It's generated in bin/save-version.sh using the date command:

      BUILD_TIME=`date`
      HEADER="# Generated version information from save-version.sh"
      echo -e \
      "${HEADER}\nVERSION: ${VERSION}\nGIT_HASH: ${GIT_HASH}\nBUILD_TIME: ${BUILD_TIME}"\
      > $IMPALA_HOME/bin/version.info
      

      It's legal to contain Non-ASCII characters depending on the locales.

      Attachments

        Activity

          People

            stigahuang Quanlong Huang
            stigahuang Quanlong Huang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: