[IMPALA-11366] Impala-shell failed to build if the build date contains Non-ASCII characters

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Infrastructure
• Epic Color: ghx-label-10
• Assignee: Quanlong Huang
• Reporter: Quanlong Huang
• Created: 17/Jun/22 00:35
• Updated: 21/Jun/22 07:32
• Resolved: 21/Jun/22 07:32

Description

I encountered a build failure locally:

Building package...
Traceback (most recent call last):
  File "setup.py", line 30, in <module>
    from impala_shell import impala_build_version
  File "/home/quanlong/workspace/Impala/shell/packaging/staging/impala_shell_package/impala_shell/impala_build_version.py", line 26
SyntaxError: Non-ASCII character '\xe5' in file /home/quanlong/workspace/Impala/shell/packaging/staging/impala_shell_package/impala_shell/impala_build_version.py on line 26, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

line 26 at shell/packaging/staging/impala_shell_package/impala_shell/impala_build_version.py does contain Non-ASCII characters:

 19 def get_version():
 20   return "4.2.0-SNAPSHOT"
 21 
 22 def get_git_hash():
 23   return "2b9d986582198903bac63e9ce8dc31c06742d3ee"
 24 
 25 def get_build_date():
 26   return "2022年 06月 17日 星期五 08:26:01 CST"

It's generated in bin/save-version.sh using the date command:

BUILD_TIME=`date`
HEADER="# Generated version information from save-version.sh"
echo -e \
"${HEADER}\nVERSION: ${VERSION}\nGIT_HASH: ${GIT_HASH}\nBUILD_TIME: ${BUILD_TIME}"\
> $IMPALA_HOME/bin/version.info

It's legal to contain Non-ASCII characters depending on the locales.