Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
ghx-label-3
Description
boroknagyz found that when building the release tarball without `-noclean` option, be/src/thirdparty will be removed. However, it won't happen in our local repo.
The reason is be/src/thirdparty is tracked in git index in our local repo. But in the release tarball there are no history so it's not in the git index. At that case, it matches the rule in .gitignore so got ignored.
The rule in .gitignore was added at the initial commit of that file: https://github.com/apache/impala/commit/edc3a5518439ed59e6c46b04d0393018aabfa8c5
commit edc3a5518439ed59e6c46b04d0393018aabfa8c5
Author: carl <carl@cloudera.com>
Date: Fri Jul 29 15:49:39 2011 -0700
IMP-8. Update build scripts, etc., to reflect thirdparty/hadoop and thirdparty/hive
Update
Checkpoint
create mode 100644 .gitignore
...
I think the purpose of it is ignoring thirdparty/hadoop and thirdparty/hive. At that time we don't have be/src/thirdparty yet (added in 2016 by IMPALA-3223). We don't have these folders now, we can consider removing that rule.