[IMPALA-11184] Log rotation can fail if FLAGS_log_filename is set with custom value

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Impala 4.0.0
• Fix Version/s: Impala 4.1.0
• Component/s: Backend
• Epic Color: ghx-label-1
• Assignee: Riza Suminto
• Reporter: Riza Suminto
• Created: 15/Mar/22 22:16
• Updated: 11/Dec/23 07:13
• Resolved: 18/Mar/22 06:02

Description

There are several places where we use FLAGS_log_filename as glob pattern:

https://github.com/apache/impala/8eeb000/master/be/src/common/logging.cc#L104  
https://github.com/apache/impala/8eeb000/master/be/src/common/logging.cc#L340 

If FLAGS_log_filename is not set, it will be initialized with google::ProgramInvocationShortName(), which will lead to correct behavior of DeleteOldLogs() and GetLatestCanonicalLogPath(). But if user set custom value to this flag, the glob pattern will mistakenly target the symlink instead of the actual log files. This can be a problem in minicluster where we start multiple impalad sharing the same log dir.

We should replace them with google::ProgramInvocationShortName().

Issue Links

• causes: IMPALA-12595 Allow automatic removal of old logs from previous PID