[IMPALA-11176] Memory leak in ClientCacheHelper

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 4.0.0, Impala 3.4.0
• Fix Version/s: Impala 4.1.0
• Component/s: Backend
• Labels: memory-leak
• Epic Color: ghx-label-6
• Assignee: Yida Wu
• Reporter: Yida Wu
• Created: 10/Mar/22 19:23
• Updated: 19/Jul/23 17:20
• Resolved: 03/Apr/22 04:37

Description

ClientCacheHelper::CreateClient uses a function pointer "factory_method" to create a new ThriftClientImpl object and store it in a share pointer of type ThriftClientImpl.

However, in the implementation of the function pointer, which uses ClientCache::MakeClient, it creates a derived object of ThriftClientImpl and return the pointer as the base object pointer ThriftClientImpl*. When the ClientCacheHelper::CreateClient uses the returned pointer to create a base shared pointer, it can't recognize that the pointer is from a derived object, therefore something goes wrong that the shared pointer couldn't release all the memory occupied by the derived object.

Issue Links

• relates to: IMPALA-11193 Assertion fails in ClientCacheTest.MemLeak