[IMPALA-11031] Listmap.getIndex() name is misleading

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Impala 4.1.0
• Component/s: Frontend
• Labels: ramp-up
• Epic Color: ghx-label-11
• Assignee: Zoltán Borók-Nagy
• Reporter: Zoltán Borók-Nagy
• Created: 19/Nov/21 16:28
• Updated: 01/Dec/21 13:46
• Resolved: 01/Dec/21 13:46

Description

Listmap.getIndex(t) modifies the ListMap object when there is no mapping for 't'.

Hence the name of it is very misleading as the reader wouldn't expect modifications from simple getters.

Probably we should just rename it to getOrAddIndex().