Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-10698

Remove branching based on MetastoreShim.getMajorVersion()

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Frontend
    • Labels:
    • Epic Color:
      ghx-label-3

      Description

      IMPALA-9731 dropped support for Hive 2 and removed most code associated with it.
      However we still have if statements that check MetastoreShim.getMajorVersion().

      One can check it with:

      git grep getMajorVersion
      

      It would be nice to get rid of these because the MetastoreShim.getMajorVersion() == 2 branches are dead code now.

      Moreover, in the test code there are still some places that check for HIVE_MAJOR_VERSION == 2, e.g.:
      https://github.com/apache/impala/blob/c10e7c969dfcc4847a8f7708940f4aa1852dbee4/tests/metadata/test_hms_integration.py#L215

      These can be also removed.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              boroknagyz Zoltán Borók-Nagy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: