Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-10662

Remove HS2 vs Beeswax differences is EE tests

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Impala 4.0.0
    • Component/s: Infrastructure
    • Labels:
      None
    • Epic Color:
      ghx-label-7

      Description

      Beeswax and HS2 results sets have some differences in precision:

      TIMESTAMP:

      • HS2 rounds to microsecond precision, while Beeswax returns nanosec
      • only differs in EE tests, impala-shell returns timestamps the same way for both protocols
      • the cause is that impyla (and dpapi in general) converts timestamps to datetime.datetime by default, which has only microsec precision

      DOUBLE/FLOAT:

      • HS2 rounds to less digits
      • differs both in EE tests and impala-shell
      • the cause is that by default Python formats strings with less precision than the stringstream we use in c++
      • there is no clear good way to format a double, string<->double conversions are inherently lossy
      • probably there is a standard way to do this in SQL, but I don't know about it

      This difference is handled in .test files with the DBAPI_RESULTS, which lets us specify different outputs for the protocols.

      I think that it would be better to remove DBAPI_RESULTS and simply format these types in HS2 to match with the beeswax output. The default conversions can be tested in impyla, while the EE tests should focus on Impala and use the maximum precision possible.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                csringhofer Csaba Ringhofer
                Reporter:
                csringhofer Csaba Ringhofer
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: