[IMPALA-1033] SOURCE keyword is a common identifier

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: Impala 1.4
• Fix Version/s: Impala 1.4
• Assignee: Matthew Jacobs
• Reporter: Matthew Jacobs
• Created: 06/Jun/14 18:05
• Updated: 08/Jun/14 21:50
• Resolved: 08/Jun/14 21:50

Description

We added a new keyword SOURCE (for DATA SOURCE ddl commands), but "source" is a very common identifier so introducing this keyword may be problematic for some users that can't easily add quotes where necessary.

There are a number of things we can consider:
1) ignoring, expecting users to change names or adding quotes
2) changing keywords "DATA SOURCE" to "DATASOURCE" or even "EXTDATASOURCE"
3) accept "source" as an identifier and then check it in the parser code (hacky)
4) have keywords that can be used as identifiers and a separate set of reserved words which cannot (likely too much work for 1.4)