Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.0-alpha1
    • None
    • None
    • Sanselan, Java on any OS

    Description

      I am submitting a patch that improves Sanselan's ICO format support. It adds:
      1. Support for Windows Vista ICO files with embedded PNGs
      2. Support for 256x256 icons (reported as 0x0)
      3. Support for top-down and bottom-up bitmaps

      Attachments

        1. sanselan-better-ico.patch
          11 kB
          Damjan Jovanovic
        2. sanselan-ico.patch
          46 kB
          Damjan Jovanovic

        Activity

          The patch against SVN HEAD.

          damjan Damjan Jovanovic added a comment - The patch against SVN HEAD.

          New version of the patch. The patch now:
          Uses only the BITMAPINFOHEADER to parse the icon (using the ICONDIRENTRY is wrong and the tests included prove it)
          Adds support for writing ICO files
          Adds support for reading 16 BPP ICO files
          Adds support for compressed bitmaps
          Adds support for the Windows Vista (and later) PNG ICO format
          Verifies crucial fields in ICO files
          Adds extensive tests

          In fact the only feature now missing is support for the alpha channel in 32 BPP bitmaps, and that is something that needs to be added to BmpImageParser along with support for BITMAPV4HEADER/BITMAPV5HEADER anyway.

          damjan Damjan Jovanovic added a comment - New version of the patch. The patch now: Uses only the BITMAPINFOHEADER to parse the icon (using the ICONDIRENTRY is wrong and the tests included prove it) Adds support for writing ICO files Adds support for reading 16 BPP ICO files Adds support for compressed bitmaps Adds support for the Windows Vista (and later) PNG ICO format Verifies crucial fields in ICO files Adds extensive tests In fact the only feature now missing is support for the alpha channel in 32 BPP bitmaps, and that is something that needs to be added to BmpImageParser along with support for BITMAPV4HEADER/BITMAPV5HEADER anyway.
          cmchen Charles Chen added a comment - patch committed. http://svn.apache.org/viewvc?view=revision&revision=995515

          People

            Unassigned Unassigned
            damjan Damjan Jovanovic
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: