[IMAGING-359] Faulty usage of URL.getFile() in tests

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0-alpha5
• Assignee: Unassigned
• Reporter: Marcono1234
• Created: 23/Jul/23 13:31
• Updated: 02/Apr/24 18:51
• Resolved: 29/Jul/23 17:58

Description

The unit tests contain a lot of code which obtains a URL from Class.getResource(String), and then calls URL.getFile() to use that as file path.

The problem is that, despite sounding similar, URL.getFile() is completely unrelated to file paths and actually returns an URL encoded value. So what this means is that you encounter a lot of test failures due to NoSuchFileException if you have the project in a directory with space (or non-ASCII characters?) in its file path.

The solution is to call URL.toURI() and then either new File(URI) or Paths.get(URI) (respectively Path.of(URI)).
Maybe a separate helper method shared by all test code is needed for this because toURI unfortunately throws a checked URISyntaxException.

Issue Links

• links to: GitHub Pull Request #306