Uploaded image for project: 'Commons Imaging'
  1. Commons Imaging
  2. IMAGING-29

IPTCParser fails after encountering record number 1

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.0-alpha1
    • None
    • None

    Description

      IPTCParser fails to find valid metadata in a JPEG after it encounters a record number 1 (it only extracts metadata from records numbered 2). A little debugging showed that this is because it was not properly moving the buffer pointer to the end of the record to pick up subsequent valid records - moving the record number check after the pointer update fixes the problem. I will attach a patch and sample image.

      Attachments

        Activity

          alexvigdor Alex Vigdor added a comment -

          The JPG file demonstrates the bug - use ImageMagick, Photoshop or an other tool and see valid IPTC metadata, but Sanselan misses it. After applying the attached patch, Sanselan does find the metadata in the JPG.

          alexvigdor Alex Vigdor added a comment - The JPG file demonstrates the bug - use ImageMagick, Photoshop or an other tool and see valid IPTC metadata, but Sanselan misses it. After applying the attached patch, Sanselan does find the metadata in the JPG.

          Thank you for your contribution!

          Patch applied in revision 1224687, resolving fixed.

          damjan Damjan Jovanovic added a comment - Thank you for your contribution! Patch applied in revision 1224687, resolving fixed.

          People

            Unassigned Unassigned
            alexvigdor Alex Vigdor
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: