[IMAGING-252] Unit Tests Fail when running under Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-alpha1
• Fix Version/s: 1.0-alpha3
• Component/s: Build, imaging.*
• Assignee: Bruno P. Kinoshita
• Reporter: Gary Lucas
• Created: 20/Mar/20 12:33
• Updated: 19/May/22 04:29
• Resolved: 09/May/22 12:07

Description

When performing a maven verify under a Windows OS, the unit test for TestImageInfo.java fails. The problem is due to the fact that the toString() method used for the test data format (BMP, I think) returns a multi-line product. Under windows, the PrintWriter class that is used internally to format the string introduces carriage returns.  But the "expected" string that the TestImageInfo class uses has  line feeds but no carriage returns.  So the assertEquals() test fails.

By tradition, Windows text includes a carriage-return/line-feed at the end of each line of text while Linux text has just a line-feed. So if these unit tests are performed on Linux, they pass. Only Windows is an issue.

Recommend including a line of code to remove the carriage-returns from the return String from the ImageInfo.toString() method call.   Instead of:

assertEquals(expected, imageInfo.toString());

use:

 

String test = imageInfo.toString().replaceAll("\\r", "");

assertEquals(expected, test);