[IMAGING-203] JPEG segment size not validated

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0-alpha1
• Component/s: Format: JPEG
• Assignee: Bruno P. Kinoshita
• Reporter: Rody Kersten
• Created: 15/Aug/17 21:27
• Updated: 07/Aug/20 04:32
• Resolved: 29/Dec/17 11:40

Description

Using my AFL-based fuzzer for Java, Kelinci (https://github.com/isstac/kelinci) I found that a NegativeArraySizeException may be throw when attempting to read an invalid JPEG image.

Each JPEG segment starts with a two-byte unsigned integer specifying the segment size. Segments are parsed by org.apache.commons.imaging.formats.jpeg.JpegUtils.traverseJFIF(). As the specified size includes these two bytes, the method subtracts 2 from the size before it is used. It then attempts to allocate a buffer for the segment, which fails if the specified size is 0 or 1. The method should throw an ImageReadException instead.