[IMAGING-199] All tEXt chunks are not returned from PngImageParser.getMetadata

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0-alpha1
• Component/s: Format: PNG
• Labels: newbie
• Assignee: Bruno P. Kinoshita
• Reporter: Ric Emery
• Created: 19/Dec/16 17:16
• Updated: 07/Aug/20 04:32
• Resolved: 13/Mar/19 08:21

Description

According to the PNG spec - Section 4.2.3 - Textual Information -

"Any number of text chunks can appear, and more than one with the same keyword is permissible. "

Unfortunately the PngImageParser.getMetadata method only supports a single tEXt chunk. The problem is in the following line:

final List<PngChunk> chunks = readChunks(byteSource, new ChunkType[]

{ ChunkType.tEXt, ChunkType.zTXt, }

, true);

True is being passed for returnAfterFirst. I believe that false should be passed instead.

I can submit a pull request if you agree.