[IMAGING-165] TiffReader.Collector adds values to a field List<TiffField> but never uses it

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0-alpha1
• Fix Version/s: 1.0-alpha2
• Component/s: Format: TIFF
• Assignee: Bruno P. Kinoshita
• Reporter: Michael Groß
• Created: 08/Feb/15 16:05
• Updated: 07/Aug/20 04:25
• Resolved: 16/Oct/19 07:44

Description

org.apache.commons.imaging.formats.tiff.TiffReader.Collector adds values to a field List<TiffField> but never uses it. This could be the cause of some problems reported elsewhere.

TiffReader contains an embedded class named Collector. This class has a private field named

private static class Collector implements Listener {
        private final List<TiffField> fields = new ArrayList<TiffField>();

There are values added in a method named

public boolean addField(final TiffField field) {
     fields.add(field);
     return true;
}

This method is the only which uses this field so these values are never used. Is there a getter missing? Or was it intended to use these values in class TiffContents like "tiffHeader" and "directories"?

public TiffContents getContents() {
    return new TiffContents(tiffHeader, directories);
}

At least the method "addField" seems unused but necessary to implement the "Listener" interface.

Issue Links

• links to: GitHub Pull Request #12