Uploaded image for project: 'Commons Imaging'
  1. Commons Imaging
  2. IMAGING-159

There should be a Parameters class

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0-alpha2
    • 1.0-alpha3
    • imaging.*

    Description

      Currently options for image I/O are defined as Maps. The leads to the problem that our code has to validate parameter types when they are used:

      final Object value = params.get(PARAM_KEY_COMPRESSION);
      if (value != null) {
        if (!(value instanceof Number)) {
          throw new ImageWriteException(
            "Invalid compression parameter, must be numeric: "
               + value);
        }
        compression = ((Number) value).intValue();
      }
      

      This can be simplified if we define a Parameters class that provides additional methods like public int getInt(String key). The implementation could then look up the value from the map through an exception if it is null or not a number.

      Attachments

        Issue Links

          Activity

            People

              kinow Bruno P. Kinoshita
              britter Benedikt Ritter
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20h 10m
                  20h 10m