[IMAGING-151] ColorGroup.color_counts is mutable public List and is multiply sorted

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0-alpha1
• Fix Version/s: 1.0-alpha2
• Assignee: Bruno P. Kinoshita
• Reporter: Sebb
• Created: 01/Jan/15 23:03
• Updated: 07/Aug/20 04:25
• Resolved: 27/Dec/19 09:06

Description

ColorGroup.color_counts is a public mutable List.
Also the List is re-sorted in several places

It looks like the field is only used within the package, so can be package protected.

However it seems odd that the shared list is re-sorted by

MedianCutLongestAxisImplementation.doCut
and
MedianCutMostPopulatedBoxesImplementation.performNextMedianCut (twice)

Issue Links

• is related to: IMAGING-117 Classes should not expose mutable arrays
• links to: GitHub Pull Request #64