[IMAGING-140] ExifReWriter always writes EXIF segment before JFIF segment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.94-incubator, 0.97, 1.x
• Fix Version/s: 1.0-alpha1
• Component/s: Format: JPEG
• Labels: EXIF

Environment

All

• Assignee: Unassigned
• Reporter: Gavin Shiels
• Created: 22/Aug/14 12:35
• Updated: 03/May/19 08:39
• Resolved: 19/Oct/14 07:03

Description

ExifRewriter.writeSegmentsReplacingExif () always writes the EXIF segment as the first segment written to the output stream even when there is JFIF segment present.

The code checks for the existence of the JFIF segment and it looks like the intention was then to insert the EXIF segment at index 1 but it is instead always inserted at index 0, the variable 'index' is not used after being set to 1.

'index' should be passed as the first parameter to the segments.add() call.

org.apache.sanselan.formats.jpeg.exifRewrite.ExifRewriter.java

int index = 0;
JFIFPieceSegment firstSegment = (JFIFPieceSegment) segments.get(index);

if (firstSegment.marker == JFIFMarker)
    index = 1;
        
segments.add(0, new JFIFPieceSegmentExif(JPEG_APP1_Marker,
markerBytes, markerLengthBytes, newBytes));