[IMAGING-131] PngImageParser#getBufferedImage() doesn't respect ImageParser specification

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0-alpha1
• Fix Version/s: 1.0-alpha1
• Component/s: Format: PNG
• Labels: easyfix
• Assignee: Unassigned
• Reporter: fasar
• Created: 25/May/14 11:12
• Updated: 03/May/19 08:39
• Resolved: 19/Oct/14 06:54

Description

ImageParser#getBufferedImage() specification tell in documentation :

ImageParser#getBufferedImage()

/**
   ...
     * @param params     Optional instructions for special-handling or
     *                   interpretation of the input data (null objects are permitted and
     *                   must be supported by implementations).
      ...
     **/

Implementation PngImageParser#getBufferedImage() does note respect this documentation. Indeed, first line of the function is :

PngImageParser#getBufferedImage() line 637

if (params.containsKey(PARAM_KEY_VERBOSE)) {
            params.remove(PARAM_KEY_VERBOSE);
        }

I suppose It would be

FIX PngImageParser#getBufferedImage()

if (params!=null && params.containsKey(PARAM_KEY_VERBOSE)) {
            params.remove(PARAM_KEY_VERBOSE);
        }