Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-9879

Web console: split major features to modules - configuration

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8
    • Component/s: wizards
    • Labels:
      None

      Description

      The issue:
      1. app.js is massive, hard to maintain and often a source of various merge conflicts.
      2. Even if some code is de facto separated by feature (configuration/queries/admin/profile), no agreement was made on how to structure directories, which leads to confusion and app.js growth.

      I propose to:
      1. Reorganize source code file structure:

      frontend
          app
              configuration
              queries
              profile
              admin
              common
      

      2. Slim app.js down to something like this:

      import common from './common'
      import configuration from './configuration'
      import queries from './queries'
      import profile from './profile'
      import admin from './admin'
      
      export default angular.module('ignite-console', [
          common.name,
          configuration.name,
          queries.name,
          profile.name,
          admin.name
      ])
      

      Each directory inside app will follow the same module structure as agreed upon before (i.e. components/services/filters, etc).
      3. In order to test water, update the configuration module first and if everything goes as expect proceed with other modules.

      Alexey Kuznetsov, Andrey Novikov what do you think?

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              pkonstantinov Pavel Konstantinov
              Reporter:
              Klaster_1 Ilya Borisov

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 16h
                16h
                Remaining:
                Time Spent - 10h 34m Remaining Estimate - 5h 26m
                5h 26m
                Logged:
                Time Spent - 10h 34m Remaining Estimate - 5h 26m
                10h 34m

                  Issue deployment