[IGNITE-9792] Setting system property IGNITE_MBEANS_DISABLED to true lead to NPE.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.7
• Assignee: Alexey Kuznetsov
• Reporter: Alexey Kuznetsov
• Created: 04/Oct/18 09:28
• Updated: 05/Oct/18 11:05
• Resolved: 05/Oct/18 10:17

Description

Javadocs for IGNITE_MBEANS_DISABLED: "This may be helpful if MBeans are not allowed e.g. for security reasons."

So I set in code:

System.setProperty(IgniteSystemProperties.IGNITE_MBEANS_DISABLED, "true")

 

And on node start node failed with NPE:

Caused by: class org.apache.ignite.IgniteCheckedException: Unexpected exception when starting grid.
 at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:2079)
 at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start(IgnitionEx.java:1728)
 at org.apache.ignite.internal.IgnitionEx.start0(IgnitionEx.java:1156)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:676)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:601)
 at org.apache.ignite.Ignition.start(Ignition.java:323)
 ... 3 more
Caused by: java.lang.NullPointerException: Ouch! Argument cannot be null: cfg.getMBeanServer()
 at org.apache.ignite.internal.util.GridArgumentCheck.notNull(GridArgumentCheck.java:48)
 at org.apache.ignite.internal.IgniteKernal.validateCommon(IgniteKernal.java:1355)
 at org.apache.ignite.internal.IgniteKernal.start(IgniteKernal.java:833)
 at org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:2033)
 ... 8 more

 

The fix is trivial: in org.apache.ignite.internal.IgniteKernal#validateCommon

if (!U.IGNITE_MBEANS_DISABLED) // <<< The fix
    A.notNull(cfg.getMBeanServer(), "cfg.getMBeanServer()");

 

Issue Links

• links to: GitHub Pull Request #4915