Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-9124

Remove some dead code in math.exceptions and optimization packages of ML module

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Done
    • 2.6
    • 2.7
    • ml

    Description

      Doing code coverage analysis discovered a bit of unused code:

      1. in package math.exceptions - classes ConvergenceException / MathIllegalStateException, InsufficientDataException, MathIllegalNumberException / NumberIsTooSmallException, NonPositiveDefiniteMatrixException, NonSymmetricMatrixException, NullArgumentException, SingularMatrixException, UnknownProviderException. In very early releases of ML these exceptions were used by some linear algebra code. This code has been very deeply reworked since but outdated exceptions were left hanging unattended, making rather confusing impression of the current API.
      2. in optimization - interface Updater and two classes implementing it: BarzilaiBorweinUpdater and SimpleUpdater. This code has left hanging after cleanup that was made for release 2.5 (IGNITE-8232). Per my discussion with dmitrievanthony (who most actively maintains this package) it would be better to remove this code.

      This task is to remove code mentioned above.

      Attachments

        Issue Links

          Activity

            People

              oignatenko Oleg Ignatenko
              oignatenko Oleg Ignatenko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: