[IGNITE-8944] TcpDiscoverySpi: set connection check frequency to fixed value

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.7
• Component/s: general
• Labels: discovery
• Assignee: Dmitry Karachentsev
• Reporter: Dmitry Karachentsev
• Created: 05/Jul/18 18:04
• Updated: 25/Jul/18 12:54
• Resolved: 25/Jul/18 12:52

Description

Now connCheckFreq value calculated by some not obvious code:

private void initConnectionCheckFrequency() {
            if (spi.failureDetectionTimeoutEnabled())
                connCheckThreshold = spi.failureDetectionTimeout();
            else
                connCheckThreshold = Math.min(spi.getSocketTimeout(), spi.metricsUpdateFreq);

            for (int i = 3; i > 0; i--) {
                connCheckFreq = connCheckThreshold / i;

                if (connCheckFreq > 10)
                    break;
            }

            assert connCheckFreq > 0;

            if (log.isInfoEnabled())
                log.info("Connection check frequency is calculated: " + connCheckFreq);
        }

It should be replaced with constant.

Issue Links

• links to: GitHub Pull Request #4320