Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-8803

Need to fix Ignite QUIET log output

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • None
    • 2.7
    • general
    • None

    Description

      We need to fix QUIET log mode. Here is an example of a single node output after another node joined and left 3 times:
       

      [22:50:23] Ignite node started OK (id=931fcf60)
      [22:50:23] Topology snapshot [ver=4, servers=2, clients=0, CPUs=8, offheap=6.4GB, heap=2.0GB]
      [22:50:23]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:50:23] Data Regions Configured:
      [22:50:23]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]
      [22:50:28] Topology snapshot [ver=5, servers=1, clients=0, CPUs=8, offheap=3.2GB, heap=1.0GB]
      [22:50:28]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:50:28] Data Regions Configured:
      [22:50:28]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]
      [22:50:36] Topology snapshot [ver=6, servers=2, clients=0, CPUs=8, offheap=6.4GB, heap=2.0GB]
      [22:50:36]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:50:36] Data Regions Configured:
      [22:50:36]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]
      [22:50:43] Topology snapshot [ver=7, servers=1, clients=0, CPUs=8, offheap=3.2GB, heap=1.0GB]
      [22:50:43]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:50:43] Data Regions Configured:
      [22:50:43]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]
      [22:50:51] Topology snapshot [ver=8, servers=2, clients=0, CPUs=8, offheap=6.4GB, heap=2.0GB]
      [22:50:51]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:50:51] Data Regions Configured:
      [22:50:51]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]
      [22:51:54] Topology snapshot [ver=9, servers=1, clients=0, CPUs=8, offheap=3.2GB, heap=1.0GB]
      [22:51:54]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:51:54] Data Regions Configured:
      [22:51:54]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]
      [22:52:02] Topology snapshot [ver=10, servers=2, clients=0, CPUs=8, offheap=6.4GB, heap=2.0GB]
      [22:52:02]   ^-- Node [id=931FCF60-03DC-44C8-BBBD-CEEF34CA6F2A, clusterState=ACTIVE]
      [22:52:02] Data Regions Configured:
      [22:52:02]   ^-- default [initSize=256.0 MiB, maxSize=3.2 GiB, persistenceEnabled=false]

       
      We are printing out the same information over and over again. For example, regions configuration does not change, why do we print it out every time? The same goes for the node ID, it stays constant. Moreover, we should never be printing out full node IDs in quite mode.
       
      I suggest we fix it as follows:

      1. Print out data regions once on startup, right before we print out that "Ignite node started OK (id=931fcf60)"
      2. Remove "^--Node [...]" printout underneath topology snapshot altogether
      3. Rename "clusterState=ACTIVE" to "state=ACTIVE" and add it to the topology snapshot line.
      4. Rename "persistenceEnabled" to "persistence"

      Attachments

        Activity

          People

            agoncharuk Alexey Goncharuk
            dsetrakyan Dmitriy Setrakyan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: