[IGNITE-8323] Assertion error during simultaneous auto-activation and manual activation

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5
• Labels: MakeTeamcityGreenAgain
• Assignee: Ilya Lantukh
• Reporter: Alexey Goncharuk
• Created: 19/Apr/18 12:36
• Updated: 23/Apr/18 14:44
• Resolved: 23/Apr/18 14:42

Description

I observe the following assertion in IgnitePdsDestroyCacheTest.testDestroyCaches

[2018-04-19 15:31:02,994][ERROR][tcp-disco-msg-worker-#131%persistence.IgnitePdsDestroyCacheTest0%][TcpDiscoverySpi] Failed to unmarshal discovery custom message.
java.lang.AssertionError: lastAffVer=AffinityTopologyVersion [topVer=3, minorTopVer=1], topVer=AffinityTopologyVersion [topVer=3, minorTopVer=1], customMsg=ChangeGlobalStateMessage [id=59bcd2ed261-f35bb298-fc8b-46dd-9d06-7800f7c11d67, reqId=01b3cf41-63e0-4ddc-80bc-a3e9b5414c14, initiatingNodeId=0fc03864-7d8a-49bb-ba8a-ff6fb8c00000, activate=true, baselineTopology=BaselineTopology [id=0, branchingHash=-1713401276, branchingType='Cluster activation', baselineNodes=[c2d35f40-7229-43b3-9342-305eb5a63897, f79b6d68-feaa-4b75-805a-8287b396b3eb, 442fe461-480c-4b32-8b81-28af4f66e165]], forceChangeBaselineTopology=false, timestamp=1524141062984]
	at org.apache.ignite.internal.processors.cache.CacheAffinitySharedManager.onDiscoveryEvent(CacheAffinitySharedManager.java:174)
	at org.apache.ignite.internal.processors.cache.GridCacheProcessor.onDiscoveryEvent(GridCacheProcessor.java:3371)
	at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery0(GridDiscoveryManager.java:694)
	at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$4.onDiscovery(GridDiscoveryManager.java:589)
	at org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.notifyDiscoveryListener(ServerImpl.java:5479)
	at org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processCustomMessage(ServerImpl.java:5305)
	at org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processMessage(ServerImpl.java:2765)
	at org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processMessage(ServerImpl.java:2536)
	at org.apache.ignite.spi.discovery.tcp.ServerImpl$MessageWorkerAdapter.body(ServerImpl.java:6775)
	at org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.body(ServerImpl.java:2621)
	at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)

From a quick investigation I see that this topology version is updated from both auto-activation and manual activation requests.
Even though this assertion does not affect this particular test, the assertion must be fixed.

Issue Links

• links to: GitHub Pull Request #3890
• links to: TC run