Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.6
    • 1.6
    • wizards
    • None

    Attachments

      Activity

        vsisko Vasiliy Sisko added a comment -

        Implemented possibility of configuration configuration of ZooKeeper IP finder.
        To test install ZooKeeper service and run it.
        Configure default port: 2181 and try to connect.
        Also test generation of secondary file system generation for IGFS and IGFS data cache affinity configuration generation.

        vsisko Vasiliy Sisko added a comment - Implemented possibility of configuration configuration of ZooKeeper IP finder. To test install ZooKeeper service and run it. Configure default port: 2181 and try to connect. Also test generation of secondary file system generation for IGFS and IGFS data cache affinity configuration generation.
        pkonstantinov Pavel Konstantinov added a comment - - edited

        Successfully in general, but I want to ask you to make more clear in tooltip what is the default value for:
        1) Retry policy
        2) Curator
        3) Set initial 'default' values for different 'Retry policy' -make these optional fields not madatory

        pkonstantinov Pavel Konstantinov added a comment - - edited Successfully in general, but I want to ask you to make more clear in tooltip what is the default value for: 1) Retry policy 2) Curator 3) Set initial 'default' values for different 'Retry policy' -make these optional fields not madatory
        vsisko Vasiliy Sisko added a comment -

        1-3 Fixed

        vsisko Vasiliy Sisko added a comment - 1-3 Fixed
        pkonstantinov Pavel Konstantinov added a comment - - edited

        1) Curator tooltip has duplicated text 'CuratorFrameworkImpl', please fix
        2) Please change the order of Default and Custom retry policy in the tooltip. 'Default' should be the last according to it position in the drop down list.

        pkonstantinov Pavel Konstantinov added a comment - - edited 1) Curator tooltip has duplicated text 'CuratorFrameworkImpl', please fix 2) Please change the order of Default and Custom retry policy in the tooltip. 'Default' should be the last according to it position in the drop down list.
        vsisko Vasiliy Sisko added a comment -

        Tooltips fixed

        vsisko Vasiliy Sisko added a comment - Tooltips fixed

        If I set the following configuration

                                <property name="retryPolicy">
                                    <bean class="org.apache.curator.retry.RetryUntilElapsed">
                                        <constructor-arg index="0" value="60000"/>
                                        <constructor-arg index="1" value="1000"/>
                                    </bean>
                                </property>
        
        

        then I getting the exception on node start

        Caused by: java.lang.NoClassDefFoundError: org/apache/curator/RetryPolicy
                at java.lang.Class.getDeclaredConstructors0(Native Method)
                at java.lang.Class.privateGetDeclaredConstructors(Class.java:2595)
                at java.lang.Class.getConstructor0(Class.java:2895)
                at java.lang.Class.getDeclaredConstructor(Class.java:2066)
                at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:80)
                at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateBean(AbstractAutowireCapableBeanFactory.java:1088)
                ... 32 more
        Caused by: java.lang.ClassNotFoundException: org.apache.curator.RetryPolicy
                at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
                at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
                at java.security.AccessController.doPrivileged(Native Method)
                at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
                at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
                at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
                at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
                ... 38 more
        
        pkonstantinov Pavel Konstantinov added a comment - If I set the following configuration <property name= "retryPolicy" > <bean class= "org.apache.curator.retry.RetryUntilElapsed" > <constructor-arg index= "0" value= "60000" /> <constructor-arg index= "1" value= "1000" /> </bean> </property> then I getting the exception on node start Caused by: java.lang.NoClassDefFoundError: org/apache/curator/RetryPolicy at java.lang. Class .getDeclaredConstructors0(Native Method) at java.lang. Class .privateGetDeclaredConstructors( Class .java:2595) at java.lang. Class .getConstructor0( Class .java:2895) at java.lang. Class .getDeclaredConstructor( Class .java:2066) at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:80) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateBean(AbstractAutowireCapableBeanFactory.java:1088) ... 32 more Caused by: java.lang.ClassNotFoundException: org.apache.curator.RetryPolicy at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang. ClassLoader .loadClass( ClassLoader .java:425) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang. ClassLoader .loadClass( ClassLoader .java:358) ... 38 more

        The previous issue already fixed in master.
        Will test with new Ignite version.

        pkonstantinov Pavel Konstantinov added a comment - The previous issue already fixed in master. Will test with new Ignite version.

        Tested.

        pkonstantinov Pavel Konstantinov added a comment - Tested.

        I'm noticed that Custom Class Name for Retry Policy is not mandatory.

        pkonstantinov Pavel Konstantinov added a comment - I'm noticed that Custom Class Name for Retry Policy is not mandatory.
        vsisko Vasiliy Sisko added a comment -

        Fixed field required state.

        vsisko Vasiliy Sisko added a comment - Fixed field required state.

        Fixed on staging, please test.

        kuaw26 Alexey Kuznetsov added a comment - Fixed on staging, please test.

        Tested.

        pkonstantinov Pavel Konstantinov added a comment - Tested.

        People

          Unassigned Unassigned
          vsisko Vasiliy Sisko
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved: