[IGNITE-23269] Sql. Reduce try/catch block used to wrap Exception into RUNTIME_ERR SqlException in ScanNode#push

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Component/s: sql
• Labels: ignite-3
• Assignee: Maksim Zhuravkov
• Reporter: Pavel Pereslegin
• Created: 25/Sep/24 10:25
• Updated: 12/Dec/24 10:04
• Resolved: 12/Dec/24 10:04

Description

Currently in ScanNode#push we handling Exception and wrapping it into SqlException with RUNTIME_ERR code.

        try {
            if (inst == null) {
                inst = func.createInstance(context());
            }

            int processed = 0;
            while (requested > 0 && inst.hasNext()) {
                checkState();

                requested--;
                downstream().push(inst.next());

                if (++processed == inBufSize && requested > 0) {
                    // allow others to do their job
                    context().execute(this::push, this::onError);

                    return;
                }
            }
        } catch (Exception e) {
            throw new SqlException(Sql.RUNTIME_ERR, e);
        }

Looks like it's done only to handle possible errors from user-side in statement

inst = func.createInstance(context());

But this try/catch block is wider then required.
For example we can catch QueryCancelledException and wrap it into RUNTIME_ERR-exception, or other internal errors wrap into RUNTIME_ERR.

Issue Links

• links to: GitHub Pull Request #4867