[IGNITE-23180] Fix fsync setting for RocksDbSharedLogStorage

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: persistence
• Labels: ignite-3
• Ignite Flags: Release Notes Required
• Assignee: Philipp Shergalis
• Reporter: Philipp Shergalis
• Reviewer: Roman Puchkovskiy
• Created: 10/Sep/24 12:48
• Updated: 11/Sep/24 06:14
• Resolved: 11/Sep/24 06:14

Description

If fsync is not set in writeOptions explicitly, rocksdb uses fsync=false, ignoring value in DBOptions. We should restore a line setting fsync option in write options for RocksDbSharedLogStorage

Without fix:

Benchmark                       (clusterSize)  (fsync)  (partitionCount)  (replicaCount)  Mode  Cnt    Score    Error  Units
InsertBenchmark.sqlInsertMulti              1    false                 4               2  avgt   20  373.648 ± 35.654  us/op
InsertBenchmark.sqlInsertMulti              1     true                 4               2  avgt   20  395.280 ± 43.948  us/op
InsertBenchmark.kvInsert              1    false                 4               2  avgt   20  70.850 ± 9.786  us/op
InsertBenchmark.kvInsert              1     true                 4               2  avgt   20  66.360 ± 4.070  us/op

(results with and without fsync are the similar, because the setting is ignored)

With fix:

Benchmark                       (clusterSize)  (fsync)  (partitionCount)  (replicaCount)  Mode  Cnt     Score      Error  Units
InsertBenchmark.sqlInsertMulti              1    false                 4               2  avgt   20   347.610 ±   39.477  us/op
InsertBenchmark.sqlInsertMulti              1     true                 4               2  avgt   20  3507.467 ± 2418.805  us/op
InsertBenchmark.kvInsert              1    false                 4               2  avgt   20   71.843 ±  19.696  us/op
InsertBenchmark.kvInsert              1     true                 4               2  avgt   20  482.806 ± 166.221  us/op

Results differ

Issue Links

• links to: GitHub Pull Request #4369