Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-19844 Tx code cleanup
  3. IGNITE-23051

Investigate GridDhtCache redundancy

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Not A Problem
    • None
    • None
    • None

    Description

      It seems, that full block of GridDhtCache initialization in GridCacheProcessor#createCacheContext is redundant: there are no further propagation of created cache context and DHT cache [1]. In case of redundancy of GridDhtCache, multiple usages of method GridNearTransactionalCache#dht() become redundant too.

      Functionality was broken since [2, 3] (before first Ignite release).

      So, we have to figure out whether this is redundant code or whether we have lost some useful functionality.

      1. https://github.com/apache/ignite/blob/b0467938fb02cd7276109d608bb1e4ac22796598/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheProcessor.java#L1395
      2. https://github.com/apache/ignite/commit/a187be6b076066f780ae9218ecddd6026759b7d0#diff-3b4ddcccb26573f109cb50ca46cd4e93a24b05adce4235caeafff2d737733156L980
      3. https://github.com/apache/ignite/commit/501bd5c39d7626094dad2e4068f823a4e05dcf42#diff-4afbbe3454964f7016a9f115afee310420bf815f9f54daebe95d6224b6f94834R1166

      Attachments

        Activity

          People

            shishkovilja Ilya Shishkov
            shishkovilja Ilya Shishkov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: