Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-19844 Tx code cleanup
  3. IGNITE-22917

Remove GridDhtLockRequest#nearKeys

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.17
    • None

    Description

      GridDhtLockRequest#addNearKey(KeyCacheObject) does not have any usage, i.e. GridDhtLockRequest#nearKeys is not updated at all.

      So, nearKeys always returns empty collection and, moreover, some code becomes useless, eg. GridNearTransactionalCache#startRemoteTx(UUID, GridDhtLockRequest) [1], etc.

      We have to figure out whether this is redundant code or whether we have lost some useful functionality.

      1. https://github.com/apache/ignite/blob/f4654f98607648252c5164c0fd1a81eff279ca26/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/near/GridNearTransactionalCache.java#L285

      Attachments

        Issue Links

          Activity

            People

              shishkovilja Ilya Shishkov
              shishkovilja Ilya Shishkov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h