[IGNITE-21482] Fix of initialization of the last version in GridCacheVersionManager

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Vladimir Steshin
• Created: 07/Feb/24 12:20
• Updated: 16/Feb/24 13:02

Description

GridCacheVersionManager has wierd initialization of its last version:

public void onLocalJoin(long topVer) {
        long startTime = cctx.kernalContext().discovery().gridStartTime();

        if (startTime != 0)
            offset = (int)((startTime - TOP_VER_BASE_TIME) / 1000);

        last = new GridCacheVersion(0, order.get(), 0, dataCenterId);
        ...
    }

topVer, nodeOrder and offset are ignored. While GridCacheVersion says 'topVer Topology version plus number of seconds from the start time of the first grid node.'. If this 'zeroed' value is read before any CRUD, a following comparation of the versions may fail. This happened in IGNITE-21236.

We should revise the initialization code. The assumed fix is:

last = new GridCacheVersion((int)topVer + offset, order.get(), (int)cctx.localNode().order(), dataCenterId);

Or we should remove this last version at all. Looks like we need only the order.

Issue Links

• is related to: IGNITE-21236 Handle DataStreamer entry version in dump
• relates to: IGNITE-21485 Refactoring of lost code and codestyle related to GridCacheVersion
• links to: GitHub Pull Request #11237
• links to: GitHub Pull Request #11246