[IGNITE-20855] Sql. Rework QueryTransactionWrapper to clean up the code.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Component/s: sql
• Labels: ignite-3
• Assignee: Pavel Pereslegin
• Reporter: Pavel Pereslegin
• Created: 14/Nov/23 12:40
• Updated: 27/Nov/23 09:55
• Resolved: 27/Nov/23 09:55

Description

It seems we can clean up the code if we move the code from wrapTxOrStartImplicit to QueryTransactionWrapper.

Basically the proposal is:

• add startTxIfNeeded(QueryType) non static void method to QueryTransactionWrapper, that will be responsible for starting implicit transaction and other checks that is now reside in static wrapTxOrStartImplicit.
• rework QueryTransactionWrapper related tests (QueryTransactionWrapperSelfTest, JdbcQueryCursorSelfTest, AsyncSqlCursorImplTest)

This will reduce the amount and complexity of code in SqlQueryProcessor (In particular when processing a multi-statements query).

The task was created based on a comment https://github.com/apache/ignite-3/pull/2789#discussion_r1392475145

Issue Links

• duplicates: IGNITE-20463 Sql. Integration of TX-related statements into sql script processor
• relates to: IGNITE-20463 Sql. Integration of TX-related statements into sql script processor