Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-20609

Move last commit timestamp into BinaryRowMessage

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0
    • None
    • Docs Required, Release Notes Required

    Description

      Motivation
      UpdateAllCommand now has two maps:
      Map<UUID, BinaryRowMessage> rowsToUpdate()
      and
      Map<UUID, Long> lastCommitTimestampsLong() and the keys in both maps denote to the same set of rows.

      We can get rid of the duplication to reduce the size of the message if instead of two maps we had a single one where the new value class would contain both BinaryRowMessage and last row commit timestamp.

      Implementation details

      1. BinaryRowMessage is used in many other places, perhaps we could subsclass it instead of adding more data to the message class itself.
      2. While implementing this task we need to be careful since currently a null BinaryRowMessage is a valid case when we perform DELETE. If we subclass BinaryRowMessage, we should also change the nullability of the row.

      Attachments

        Issue Links

          Activity

            People

              v.pyatkov Vladislav Pyatkov
              ksizov  Kirill Sizov
              Kirill Sizov Kirill Sizov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m