[IGNITE-20523] .NET: Thin 3.0: ArgumentNullException.ThrowIfNull allocates on value types

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.0.0-beta1
• Fix Version/s: 3.0.0-beta2
• Component/s: platforms, thin client
• Labels: .NET ignite-3

Language

C#

• Assignee: Pavel Tupitsyn
• Reporter: Pavel Tupitsyn
• Reviewer: Igor Sapego
• Created: 02/Oct/23 07:29
• Updated: 05/Oct/23 05:33

Description

IGNITE-20479 replaced custom null checks with standard ArgumentNullException.ThrowIfNull. However, ThrowIfNull takes object, which involves boxing for value types. Therefore we do heap allocations just to validate arguments in some cases, such as generic record/key/value validation in KeyValueView and RecordView. Bring back the custom generic validation method to fix this.

Also, ToKv method validates the wrong thing twice:

    private static KvPair<TK, TV> ToKv(KeyValuePair<TK, TV> x)
    {
        ArgumentNullException.ThrowIfNull(x);
        ArgumentNullException.ThrowIfNull(x);

        return new(x.Key, x.Value);
    }

Issue Links

• is caused by: IGNITE-20479 .NET: Thin 3.0: Replace IgniteArgumentCheck.NotNull with ArgumentNullException.ThrowIfNull
• links to: GitHub Pull Request #2661