[IGNITE-20002] Implement durable unlock on primary partition re-election

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Labels: ignite-3 transaction transaction3_recovery
• Epic Link: Tx on unstable topology: commit partition recovery
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Denis Chudov
• Reporter: Alexander Lapin
• Reviewer: Vladislav Pyatkov
• Created: 19/Jul/23 05:58
• Updated: 04/Sep/24 16:10
• Resolved: 20/Oct/23 08:13

Description

Motivation

It's required to release all acquired locks on transaction finish in a durable way. Such durability consists of two parts:

• Durable unlock within same primary.
• Durable unlock on primary change.

This ticket is about second part only. There's a counterpart ticket for the first part IGNITE-20004

Definition of Done

• All unreleased locks for the transactions that were finished are released in case of primary re-election, including old primary failure and cluster restart.

Implementation Notes

• We may start with adding onPrimaryElected callback.
• Within this callback, it's required to scan `org.apache.ignite.internal.tx.storage.state.TxStateStorage#scan` local TxStateStorage and call `org.apache.ignite.internal.tx.TxManager#cleanup` for all transactions that have false in TxMeta.locksReleased. TxManager#cleanup is an idempotent operation, thus it's safe to run it multiple time, even from different nodes, e.g. old primary and new primary.
• It's required to add locksReleased field to TxMeta with default value false.
• It's required to set locksReleases to true when all cleanup txCleanupReplicaRequest returns successfully. That extra "updateTxnState(locksReleased == true) should be asynchronous.
• Tests will be non-trivial here, because it'll be required to kill old primary after txnStateChanged but before sending cleanup request.

 

Issue Links

• links to: GitHub Pull Request #2697