Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-19358

Sql. PrepareServiceImpl prepareDML cache does not take dynamic parameters into account

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha2
    • None
    • sql

    Description

      PrepareService prepareDml cache does not take dynamic parameters into account which can potentially lead to runtime errors when different queries reuse the same plan.

          private CompletableFuture<QueryPlan> prepareDml(SqlNode sqlNode, PlanningContext ctx) {
              var key = new CacheKey(ctx.schemaName(), sqlNode.toString());
              ....
      

      Expected behaviour: dml plan cache should take dynamic parameters/types of dynamic parameters into account.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            mzhuravkov Maksim Zhuravkov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment