[IGNITE-19034] VisorSnapshotStatusTask returns empty result for restoring snapshot until snapshot check is completed

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: iep-43 ise
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Nikita Amelchev
• Reporter: Ilya Shishkov
• Created: 15/Mar/23 09:02
• Updated: 05/Jun/24 11:54

Description

Currently, snapshot check is performed under the hood during restoring of a snapshot. For big snapshots check operation execution can take a long time.
In such case, if you call two similar commands, they will return different results:
Deprecated command restore --status shows, that snapshot operation is in progress:

Command [SNAPSHOT] started
Arguments: --snapshot restore test_snapshot --status 
--------------------------------------------------------------------------------
Command deprecated. Use '--snapshot status' instead.
Snapshot cache group restore operation is running [snapshot=test_snapshot]
Command [SNAPSHOT] finished with code: 0

But actual command --snapshot status does not show that any snapshot operation is running:

Command [SNAPSHOT] started
Arguments: --snapshot status 
--------------------------------------------------------------------------------
There is no create or restore snapshot operation in progress.
Command [SNAPSHOT] finished with code: 0

VisorSnapshotStatusTask.java rely on snapshot restore metrics[1]. This metrics are extracted from SnapshotRestoreProcess#lastOpCtx [2], which is updated in SnapshotRestoreProcess#prepare [3], but this method called after snapshot check is finished [4, 5].

Here is a reproducer: SnapshotStatusReproducerTest.patch

Links:

1. https://github.com/apache/ignite/blob/a8e16899514348ed7b9404e7d122ed430f8e1acd/modules/core/src/main/java/org/apache/ignite/internal/visor/snapshot/VisorSnapshotStatusTask.java#L141
2. https://github.com/apache/ignite/blob/a8e16899514348ed7b9404e7d122ed430f8e1acd/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java#L245
3. https://github.com/apache/ignite/blob/a8e16899514348ed7b9404e7d122ed430f8e1acd/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java#L670
4. https://github.com/apache/ignite/blob/a8e16899514348ed7b9404e7d122ed430f8e1acd/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java#L414
5. https://github.com/apache/ignite/blob/a8e16899514348ed7b9404e7d122ed430f8e1acd/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotRestoreProcess.java#L205

Issue Links

• Dependency: IGNITE-19972 Add metrics of snapshot check
• incorporates: IGNITE-22383 Status and progress of snapshot checking
• relates to: IGNITE-19144 Restore snapshot skipCheck mode
• links to: GitHub Pull Request #10820