[IGNITE-18588] .NET: Thin 3.0: BinaryTupleReader incorrect behavior on type mismatch

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-beta1
• Fix Version/s: 3.0
• Component/s: platforms, thin client
• Labels: .NET ignite-3
• Assignee: Pavel Tupitsyn
• Reporter: Pavel Tupitsyn
• Reviewer: Igor Sapego
• Created: 19/Jan/23 14:35
• Updated: 04/Sep/24 16:19
• Resolved: 20/Jan/23 10:21

Description

Add the following test to BinaryTupleTests:

[Test]
public void TestShortAsByte()
{
    var bytes = Build((ref BinaryTupleBuilder b) => b.AppendShort(257));
    var reader = new BinaryTupleReader(bytes, 1);

    Assert.AreEqual(257, reader.GetByte(0));
}

The result is assertion failure "Expected: 257 But was: 1" - we get incorrect value, but there should be an exception when the data does not fit into the requested type.

Issue Links

• blocks: IGNITE-18478 .NET: Thin 3.0: Add ExecuteReader to SQL API
• links to: GitHub Pull Request #1554
• links to: IGNITE-18588 .NET: Fix BinaryTupleReader behavior on payload size mismatch by ptupitsyn · Pull Request #1554 · apache/ignite-3