[IGNITE-18432] SafeTimeCandidateManager#commitIndex() fails assertion if indices have different terms

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta2
• Labels: ignite-3
• Epic Link: Storage support for Rebalancing
• Assignee: Denis Chudov
• Reporter: Roman Puchkovskiy
• Reviewer: Roman Puchkovskiy
• Created: 20/Dec/22 11:32
• Updated: 22/Dec/22 14:02
• Resolved: 22/Dec/22 14:02

Description

SafeTimeCandidateManager#commitIndex() accepts a range of indices and a term corresponding to the last of these indices. It then tries to look up the corresponding timestamps by (index, term) pair.

It might happen that it gets an interval of indices where some of them have one term, others have another term (in other words, the batch it gets might contain indices from different terms). Example:

1. A command with index 29 and term 1 is applied
2. Leader is changed and new configuration 'entry' is applied with index 30 and term 2
3. commitIndex() is called for this batch with lastIndex=28, index=30 and term 2, so it tries to look up an index (29,1) and fails to do so, failing the assertion

Issue Links

• relates to: IGNITE-18079 Integrate RAFT streaming snapshots
• links to: GitHub Pull Request #1466