[IGNITE-18181] Race during table creation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta2
• Labels: ignite-3
• Assignee: Roman Puchkovskiy
• Reporter: Roman Puchkovskiy
• Reviewer: Vladislav Pyatkov
• Created: 17/Nov/22 08:08
• Updated: 17/Nov/22 09:51
• Resolved: 17/Nov/22 09:28

Description

tablesByIdVV.update() inside TableManager#updateAssignments initiates async RAFT groups' start, but its future supplier returns completedFuture(null), so there is no causal dependency between completion of what update() returned and the futures that start RAFT groups; hence, there is no causal dependency between completing 'table created' future and RAFT groups start.

While updateAssignmentsInternal is fully synchronous, this is not a problem. But in IGNITE-18170 we make it async, and here the race starts manifesting itself.

Probably, update supplier should return a future depending on RAFT group start future and not just a completed future.

Issue Links

• blocks: IGNITE-18170 Deadlock in TableManager#updateAssignmentInternal()
• links to: GitHub Pull Request #1351