[IGNITE-17968] Seems that mvDataStorage.scan doesn't return pending removed value as writeIntent

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta1
• Labels: ignite-3 transaction3_ro
• Epic Link: Ignite 3 transactions
• Assignee: Semyon Danilov
• Reporter: Alexander Lapin
• Reviewer: Roman Puchkovskiy
• Created: 24/Oct/22 20:22
• Updated: 01/Nov/22 12:19
• Resolved: 26/Oct/22 16:57

Description

Following test will work

@Test
public void testReadOnlyGetWriteIntentResolutionUpdate() {
    accounts.recordView().upsert(null, makeValue(1, 100.));

    // Pending tx
    Transaction tx = igniteTransactions.begin();
    accounts.recordView().upsert(tx, makeValue(1, 300.));

    // Update
    Transaction readOnlyTx = igniteTransactions.readOnly().begin();
    assertEquals(100., accounts.recordView().get(readOnlyTx, makeKey(1)).doubleValue("balance"));
}

And following won't

@Test
public void testReadOnlyGetWriteIntentResolutionRemove() {
    accounts.recordView().upsert(null, makeValue(1, 100.));

    // Pending tx
    Transaction tx = igniteTransactions.begin();
    accounts.recordView().delete(tx, makeKey(1));

    // Remove.
    Transaction readOnlyTx = igniteTransactions.readOnly().begin();
    assertEquals(100., accounts.recordView().get(readOnlyTx, makeKey(1)).doubleValue("balance"));
} 

Internally mvDataStorage.scan(readTimestamp) in PartitionReplicaListener#processReadOnlyMultiEntryAction will skip such pending removed entries.

Please pay attention that writeIntetns that contain data (update pending modification instead of remove one) works propertly. See ItTxDistributedTestSingleNode#testReadOnlyGetWriteIntentResolutionUpdate and ItTxDistributedTestSingleNode#testReadOnlyPendingWriteIntentSkipped for more details.

Reproducers:

ItTxDistributedTestSingleNode#testReadOnlyGetWriteIntentResolutionRemove

ItTxDistributedTestSingleNode#testReadOnlyPendingWriteIntentSkippedCombined

Issue Links

• links to: GitHub Pull Request #1252