[IGNITE-17851] TX cache update counter must deny already closed gaps re-closing

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: ise
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Unassigned
• Reporter: Anton Vinogradov
• Created: 07/Oct/22 15:15
• Updated: 27/May/24 13:30

Description

Currently PartitionUpdateCounterTrackingImpl#update() just returns false when closing already closed gaps.
The result is ignored on non-rollback calls at IgniteTxHandler#applyPartitionsUpdatesCounters().
Such behaviour allows to reuse the same counter and this may lead to the hidden inconsistency.

I've checked that PartitionUpdateCounterTrackingImpl#update() never returns false on non-rollback call, using the Check, but we must guarantee this.

PartitionUpdateCounterTrackingImpl#update() method should be refactored to provide only-once closing guarantee or IgniteTxHandler#applyPartitionsUpdatesCounters() shoud check the update result for every the call (including non-rollback).

 

Issue Links

• blocks: IGNITE-22344 Tx counters refactoring
• links to: Check