Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-16061

Make BinaryMarshaller#setBinaryContext() public

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.13
    • binary
    • None

    Description

      BinaryMarshaller#setBinaryContext() method is required to initialize BinaryMarshaller, without this method invocation BinaryMarshaller cannot be used. But the method is private and it never gets invoked from BinaryMarshaller code itself. Instead, it is always called from other classes using reflection, like this:

      IgniteUtils.invoke(BinaryMarshaller.class, bMarsh0, "setBinaryContext", binaryCtx, ctx.config());

      So, in reality, the method is handled like it's public, but as it is actually private, reflection has to be used as a work-around.

      It seems better to just make the method public.

      Attachments

        Issue Links

          Activity

            People

              rpuch Roman Puchkovskiy
              rpuch Roman Puchkovskiy
              Kirill Tkalenko Kirill Tkalenko
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m