Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-15921

Vulnerability in thin client protocol leads to OOM

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.11
    • 2.13
    • thin client
    • Fixed potential OOM in thin client protocol handler caused by malicious or garbage data.
    • Docs Required, Release Notes Required

    Description

      As thin client protocol interprets first 4 bytes as message size and allocate array for it. Any "big" 4 bytes sent on thin client port could leads to OOM.

      Some ideas to resolve:
       - print WARN in case of big client message
       - allocate array not for all message, but allocate it gradually.
       - read more then first4 bytes to understand is it real client message, or it is some trash.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ptupitsyn Pavel Tupitsyn
            kazakov Ilya Kazakov
            Igor Sapego Igor Sapego
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                Slack

                  Issue deployment