[IGNITE-15867] Socket shutdown called twice in GridNioServer

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.11
• Fix Version/s: 2.13
• Component/s: networking
• Labels: ise.lts
• Release Note: Fixed logging non-informative ClosedChannelException
• Ignite Flags: Release Notes Required
• Assignee: Roman Puchkovskiy
• Reporter: Ilya Korol
• Reviewer: Sergey Chugunov
• Created: 03/Nov/21 05:12
• Updated: 13/May/22 09:02
• Resolved: 16/Dec/21 08:48

Description

After fixing IGNITE-15367 calling GridNioServer$AbstractNioClientWorker.closekey(SelectionKey key) would produce excessive java.nio.channels.ClosedChannelException because sock.shutdownInput() and sock.shutdownInput() would be called twice:

// GridNioServer$AbstractNioClientWorker

private void closeKey(SelectionKey key) {
    // Shutdown input and output so that remote client will see correct socket close.
    Socket sock = ((SocketChannel)key.channel()).socket();

    try {
        try {
            sock.shutdownInput();           // <-- First time
        }
        catch (IOException ignored) {
            // No-op.
        }

        try {
            sock.shutdownOutput();          // <-- First time
        }
        catch (IOException ignored) {
            // No-op.
        }
    }
    finally {
        U.close(key, log);                  // <-- Second time
        U.close(sock, log);                 // <-- Second time
    }
}

Issue Links

• links to: GitHub Pull Request #9651